Skip to content

Conversation

gmourier
Copy link
Member

Pull Request

What does this PR do?

  • Remove properties that do not exist for the webhooks API telemetry

PR checklist

Please check if your PR fulfills the following requirements:

  • [] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

Just to confirm, does this mean we are not tracking anything relating to webhooks?

@gmourier
Copy link
Member Author

gmourier commented Sep 1, 2025

We are tracking events, like when a webhook is updated but we track no properties in those events

Copy link
Member

hmmm…I wonder if we should start including the tracked events in the telemetry page, but that's a whole other discussion

guimachiavelli
guimachiavelli previously approved these changes Sep 1, 2025
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guimachiavelli guimachiavelli merged commit 6e7bfa4 into main Sep 1, 2025
3 checks passed
@guimachiavelli guimachiavelli deleted the fix-telemetry-info-for-webhooks branch September 1, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants